Snapshotted. See replies below.
http://codereview.appspot.com/136053/diff/7001/7039 File src/com/google/caja/cajita-module.js (right): http://codereview.appspot.com/136053/diff/7001/7039#newcode270 src/com/google/caja/cajita-module.js:270: // this should not happen On 2009/11/11 20:25:25, metaweta wrote:
Throw an informative exception.
Good point, done. Not sure what an *informative* exception is here, but I threw something. This will get bubbled up to the top-level <script> onload event, which will probably drop it on the floor, but it might show up in a debugger and we can see it if it happens in reality. Which it shouldn't. But.... http://codereview.appspot.com/136053/diff/7001/7059 File src/com/google/caja/service/HtmlHandler.java (right): http://codereview.appspot.com/136053/diff/7001/7059#newcode67 src/com/google/caja/service/HtmlHandler.java:67: "http://caja.appspot.com/cajoler";; On 2009/11/11 20:25:25, metaweta wrote:
Good catch
We are _sporty_! http://codereview.appspot.com/136053/diff/7001/7007 File tests/com/google/caja/a.js (right): http://codereview.appspot.com/136053/diff/7001/7007#newcode23 tests/com/google/caja/a.js:23: x + y On 2009/11/11 20:25:25, metaweta wrote:
semicolon
Done. http://codereview.appspot.com/136053/diff/7001/7022 File tests/com/google/caja/c.js (right): http://codereview.appspot.com/136053/diff/7001/7022#newcode23 tests/com/google/caja/c.js:23: x + 1 On 2009/11/11 20:25:25, metaweta wrote:
semicolon
Done. http://codereview.appspot.com/136053/diff/7001/7020 File tests/com/google/caja/opensocial/DefaultGadgetRewriterTest.java (right): http://codereview.appspot.com/136053/diff/7001/7020#newcode99 tests/com/google/caja/opensocial/DefaultGadgetRewriterTest.java:99: } On 2009/11/11 22:46:34, MikeSamuel wrote:
How is this test different from testSocialHelloWorld on line 101 now?
It's not. Bobbitted. http://codereview.appspot.com/136053/diff/7001/7023 File tests/com/google/caja/plugin/domita_test.html (right): http://codereview.appspot.com/136053/diff/7001/7023#newcode315 tests/com/google/caja/plugin/domita_test.html:315: // TODO(mikesamuel): rewrite XHR and setTimeout tests to use this scheme. On 2009/11/11 22:46:34, MikeSamuel wrote:
plz wrap or maybe deindent this entire script block body
Went with the deindenting. http://codereview.appspot.com/136053/diff/7001/7023#newcode377 tests/com/google/caja/plugin/domita_test.html:377: 'assert', 'assertContains', 'assertEquals', 'assertEvaluatesToFalse', On 2009/11/11 22:46:34, MikeSamuel wrote:
plz wrap
Done. http://codereview.appspot.com/136053/diff/7001/7023#newcode438 tests/com/google/caja/plugin/domita_test.html:438: return 'http://gadget-proxy/?url=' + encodeURIComponent(uri) On 2009/11/11 22:46:34, MikeSamuel wrote:
plz wrap
Done. http://codereview.appspot.com/136053/diff/7001/7023#newcode448 tests/com/google/caja/plugin/domita_test.html:448: // Create a readonly mirror of document so that we can test that mutations On 2009/11/11 22:46:34, MikeSamuel wrote:
plz wrap
Done. http://codereview.appspot.com/136053/diff/7001/7026 File tests/com/google/caja/plugin/jsunit.js (right): http://codereview.appspot.com/136053/diff/7001/7026#newcode57 tests/com/google/caja/plugin/jsunit.js:57: console.log('TEST ERROR: pass without a test ID'); On 2009/11/11 22:46:34, MikeSamuel wrote:
Maybe console.error instead of console.log
Done. http://codereview.appspot.com/136053
