http://codereview.appspot.com/273041/diff/14001/15002
File pom.xml (right):

http://codereview.appspot.com/273041/diff/14001/15002#newcode1
pom.xml:1: <?xml version="1.0" encoding="UTF-8"?>
Should this file should be in the maven directory?

http://codereview.appspot.com/273041/diff/14001/15002#newcode41
pom.xml:41: <version>r3950</version>
I am not too familiar with maven.  Is it possible to not have to specify
a particular version of Caja here but to use the same one as specified
by the caja pom.xml?

http://codereview.appspot.com/273041/diff/14001/15001
File src/main/java/com/google/caja/tools/CajaIctMojo.java (right):

http://codereview.appspot.com/273041/diff/14001/15001#newcode41
src/main/java/com/google/caja/tools/CajaIctMojo.java:41: public class
CajaIctMojo extends AbstractMojo {
Since this is the general maven plugin point for Caja, I suggest calling
it CajaMojo or something else not ICT specific.

http://codereview.appspot.com/273041/diff/14001/15001#newcode105
src/main/java/com/google/caja/tools/CajaIctMojo.java:105:
scanner.setIncludes(new String[]{"**/*.js"});
Can the includes and excludes also be configurable in the pom as the
source directory is - perhaps with some defaults.

http://codereview.appspot.com/273041/show

Reply via email to