Comment #11 on issue 271 by limpbizkit: Scopes.SINGLETON + null doesn't work http://code.google.com/p/google-guice/issues/detail?id=271
I took a look at the patch; very nice! A few questions: - why create a class for the sentinel? It would be simpler and have less overhead to use "public static final Object NULL = new Object()" - why create a Reference wrapper for singletons? This is inner-loop code so we should avoid unnecessary wrapping layers wherever possible (and go with the sentinel approach). -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "google-guice-dev" group. To post to this group, send email to google-guice-dev@googlegroups.com To unsubscribe from this group, send email to google-guice-dev+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/google-guice-dev?hl=en -~----------~----~----~----~------~----~------~--~---
