we considered every possibility. it is not possible to select the appropriate pipeline and maintain backwards compat without doing what we have done. or leaking lots of abstraction to the user.
in any case the static fields dont hurt anyone and the only side effect is that certain types of tests can't be run concurrently (in the same vm). this is pretty negligible compared to the pain of breaking backwards compat and the ability to constructor inject filters and servlets, etc. dhanji On 12/26/08, Chandra <[email protected]> wrote: > > GuiceFilter has static fields for servletContext and for Filter > pipeline. If ServletModule constructor takes ServletContext and > GuiceServletContextListener is required in web.xml then GuiceFilter > code can be static free. If backward compatibility is desired, then it > doesn't seem possible to make GuiceFilter completely static free but > deprecating no arg constructor of ServletModule open the possibility > to do it in future. > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "google-guice" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/google-guice?hl=en -~----------~----~----~----~------~----~------~--~---
