On 7 October 2010 14:03, Sam Berlin <[email protected]> wrote: > SGTM. This is just pure SVN moves, no code-changes (except for possibly > some in the build.xml & build.properties files), right? >
correct, it's just shuffling directories and updating the ant properties > sam > > > On Thu, Oct 7, 2010 at 8:27 AM, Stuart McCulloch <[email protected]>wrote: > >> On 7 October 2010 13:19, Sam Berlin <[email protected]> wrote: >> >>> Can you clarify what you mean by "move the core code into it's own >>> directory"? >>> >> >> something like this: >> >> core/src/main/java/... >> core/src/test/java/... >> extensions/assistedinject/src/main/java... >> extensions/assistedinject/src/test/java/... >> >> http://github.com/sonatype/sisu-guice >> >> you can still get the ant scripts to work with such a structure, but maven >> won't work well with the current structure of: >> >> src/... >> test/... >> extensions/assistedinject/src/... >> extensions/assistedinject/test/... >> >> >>> sam >>> >>> >>> On Thu, Oct 7, 2010 at 5:46 AM, Stuart McCulloch <[email protected]>wrote: >>> >>>> On 6 October 2010 11:38, Dhanji R. Prasanna <[email protected]> wrote: >>>> >>>>> Spoke to Jason offline. If you are able, you should check these poms >>>>> in. >>>> >>>> >>>> I'd also like to move the core code into it's own directory and align >>>> the source and test directories >>>> to match what maven expects (src/main/java and src/test/java) - ant >>>> doesn't care about the layout >>>> so it's much easier to use this convention (and amend the ant scripts to >>>> use it) than force maven >>>> to use the ant layout - especially once you get IDEs involved >>>> >>>> would it be better if I made these changes on a branch so you can review >>>> the new layout? >>>> >>>> Dhanji. >>>>> >>>>> On Wed, Oct 6, 2010 at 9:00 PM, Stuart McCulloch <[email protected]>wrote: >>>>> >>>>>> On 5 October 2010 05:22, Dhanji R. Prasanna <[email protected]> wrote: >>>>>> >>>>>>> Nice! Will these poms work with Guice core? >>>>>> >>>>>> >>>>>> yes, they already build core (both AOP and no-AOP flavours) and the >>>>>> extensions - next step is to add the doclava doclet >>>>>> >>>>>> >>>>>>> Dhanji. >>>>>>> >>>>>>> On Tue, Oct 5, 2010 at 3:14 AM, Jason van Zyl < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>>> FYI, >>>>>>>> >>>>>>>> I just finished building Guice along with all the extensions using >>>>>>>> the build that Stuart put together: >>>>>>>> >>>>>>>> http://gist.github.com/609958 >>>>>>>> >>>>>>>> Should be possible doing the following: >>>>>>>> >>>>>>>> git clone http://github.com/sonatype/sisu-guice.git >>>>>>>> cd sisu-guice >>>>>>>> mvn clean install >>>>>>>> >>>>>>>> Thanks, >>>>>>>> >>>>>>>> Jason >>>>>>>> >>>>>>>> ---------------------------------------------------------- >>>>>>>> Jason van Zyl >>>>>>>> Founder, Apache Maven >>>>>>>> http://twitter.com/jvanzyl >>>>>>>> --------------------------------------------------------- >>>>>>>> >>>>>>>> We know what we are, but know not what we may be. >>>>>>>> >>>>>>>> -- Shakespeare >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> You received this message because you are subscribed to the Google >>>>>>>> Groups "google-guice" group. >>>>>>>> To post to this group, send email to [email protected]. >>>>>>>> To unsubscribe from this group, send email to >>>>>>>> [email protected]<google-guice%[email protected]> >>>>>>>> . >>>>>>>> For more options, visit this group at >>>>>>>> http://groups.google.com/group/google-guice?hl=en. >>>>>>>> >>>>>>> >>>>>>> -- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "google-guice" group. >>>>>>> To post to this group, send email to [email protected]. >>>>>>> To unsubscribe from this group, send email to >>>>>>> [email protected]<google-guice%[email protected]> >>>>>>> . >>>>>>> For more options, visit this group at >>>>>>> http://groups.google.com/group/google-guice?hl=en. >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Cheers, Stuart >>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "google-guice" group. >>>>>> To post to this group, send email to [email protected]. >>>>>> To unsubscribe from this group, send email to >>>>>> [email protected]<google-guice%[email protected]> >>>>>> . >>>>>> For more options, visit this group at >>>>>> http://groups.google.com/group/google-guice?hl=en. >>>>>> >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "google-guice" group. >>>>> To post to this group, send email to [email protected]. >>>>> To unsubscribe from this group, send email to >>>>> [email protected]<google-guice%[email protected]> >>>>> . >>>>> For more options, visit this group at >>>>> http://groups.google.com/group/google-guice?hl=en. >>>>> >>>> >>>> >>>> >>>> -- >>>> Cheers, Stuart >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "google-guice" group. >>>> To post to this group, send email to [email protected]. >>>> To unsubscribe from this group, send email to >>>> [email protected]<google-guice%[email protected]> >>>> . >>>> For more options, visit this group at >>>> http://groups.google.com/group/google-guice?hl=en. >>>> >>> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "google-guice" group. >>> To post to this group, send email to [email protected]. >>> To unsubscribe from this group, send email to >>> [email protected]<google-guice%[email protected]> >>> . >>> For more options, visit this group at >>> http://groups.google.com/group/google-guice?hl=en. >>> >> >> >> >> -- >> Cheers, Stuart >> >> -- >> You received this message because you are subscribed to the Google Groups >> "google-guice" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]<google-guice%[email protected]> >> . >> For more options, visit this group at >> http://groups.google.com/group/google-guice?hl=en. >> > > -- > You received this message because you are subscribed to the Google Groups > "google-guice" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<google-guice%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/google-guice?hl=en. > -- Cheers, Stuart -- You received this message because you are subscribed to the Google Groups "google-guice" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/google-guice?hl=en.
