On 13 October 2010 05:27, Dhanji R. Prasanna <[email protected]> wrote:
> OK, I had a chat with Jesse--let's go ahead and change the dir layout in > the maven style, given the following caveats: > - We need to make sure the ant build still works > - Maven should produce the same artifact as Ant (with jarjar'ed internals). > I don't think it serves us to have divergent binaries. > - We should not need to make any source code changes in Guice. > excellent - I'll write up the steps for moving the directories and attach a patch for the ant scripts so you can review them once the new layout is in place the additional pom.xml changes can go in without disturbing anything else btw, at the moment I'm using the shade plugin in place of jarjar - but I'm also thinking about resurrecting/updating the Atlassian jarjar plugin I already have a plugin to munge the no-AOP build (called munge-maven-plugin) which works the same as the Ant task Dhanji. > > > On Wed, Oct 13, 2010 at 3:24 PM, Jason van Zyl <[email protected]>wrote: > >> >> On Oct 12, 2010, at 10:46 PM, Dhanji R. Prasanna wrote: >> >> Haha, that's very kind. >> >> I am not arguing against this change per se. In fact, I do want to support >> maven for everyone who uses it. However, changing the dir layout is a bit >> more drastic than my original suggestion, so I would have to get consensus >> from the entire Guice team (Bob, Jesse, Fred, et al, even though Sam and >> Stuart are on board), and our priorities may be slightly different--we want >> to make it easy for both Google-internal and external contributors, we do >> not have any resources other than Java files, etc., so we have to balance >> these pressures =) >> >> >> And I have zero interest in making anyone use Maven if they don't want to. >> But if you don't want to take the POMs as we submitted them, then don't use >> them. Stuart and I can do a better job at supporting Maven users from our >> side because the build we have we know will work in IDEs and anything else >> Maven related because we use the build output everyday. >> >> We'll make sure there is a build of the release in Maven Central with >> proper javadocs and sources with POMs that work. We'll also make sure users >> can clone Guice out of git and just build. We'll keep the repo up-to-date >> with a automatic sync. You don't need to do any work. It's no burden for us >> because we've been doing it for quite some time, and it's in all of our >> products so there shouldn't be any fear about us dropping off the face of >> the planet. >> >> That having been said I'm definitely interested in keeping our maven users >> happy, so will aim for something works well for everyone involved. >> >> Dhanji. >> >> On Wed, Oct 13, 2010 at 9:21 AM, Andrei Pozolotin < >> [email protected]> wrote: >> >>> Dhanji, hello; >>> >>> just a note from a very intrested bystander: >>> >>> you are a world-renown book author and genius of depenency injection; >>> >>> can you please just accept Jason view on build system setup? >>> >>> "there is no right or wrong but thinking makes it so", right? >>> >>> delay of joy (and guice) is needless! :-) >>> >>> thank you; >>> >>> Andrei >>> >>> >>> On Oct 12, 4:56 pm, Jason van Zyl <[email protected]> wrote: >>> > On Oct 9, 2010, at 8:34 PM, Dhanji R. Prasanna wrote: >>> > > On Sun, Oct 10, 2010 at 3:31 AM, Mingfai <[email protected]> >>> wrote: >>> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "google-guice" group. >>> To post to this group, send email to [email protected]. >>> To unsubscribe from this group, send email to >>> [email protected]<google-guice%[email protected]> >>> . >>> For more options, visit this group at >>> http://groups.google.com/group/google-guice?hl=en. >>> >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "google-guice" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group at >> http://groups.google.com/group/google-guice?hl=en. >> >> >> Thanks, >> >> Jason >> >> ---------------------------------------------------------- >> Jason van Zyl >> Founder, Apache Maven >> http://twitter.com/jvanzyl >> --------------------------------------------------------- >> >> In short, man creates for himself a new religion of a rational >> and technical order to justify his work and to be justified in it. >> >> -- Jacques Ellul, The Technological Society >> >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "google-guice" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]<google-guice%[email protected]> >> . >> For more options, visit this group at >> http://groups.google.com/group/google-guice?hl=en. >> > > -- > You received this message because you are subscribed to the Google Groups > "google-guice" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<google-guice%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/google-guice?hl=en. > -- Cheers, Stuart -- You received this message because you are subscribed to the Google Groups "google-guice" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/google-guice?hl=en.
