On 18 October 2010 19:25, Brian Pontarelli <[email protected]> wrote:
> adding a maven build alongside the ant build has other benefits - it helps >> people who want to build with maven, or have IDEs that integrate better with >> maven >> >> >> Not really. If there are targets to produce Maven artifacts and publish >> them locally or remotely then Guice can be easily integrated with Maven. >> > > I was speaking more of people who want to build Guice itself with Maven, > and not just consume the occasional artifact pushed to Maven central > > this is useful both for Maven-based developers who want to contribute back > to Guice and also for people debugging problems inside Guice itself > > > I think it is presumptuous to ask a project to change their build tool. > nowhere in http://code.google.com/p/google-guice/issues/detail?id=552 does it say guice should change its build tool the main thing we're asking is that the core source code is moved to a subdirectory called "core" (or something similar) - this is imho a good thing regardless of the build system involved as I mentioned before on this thread the other changes to use the maven layout are _not_ essential, but again these changes don't stop people building with either ant or maven I'm a committer on projects that use Ant, Maven, Savant, Gradle, Rake, and > others. I wouldn't ask those projects to change. If I need an artifact from > one of those projects in one of my projects, I generally write simple > scripts to copy them into my Savant repository. > > I'm also leery of "maven-based" developers. This is a religious debate, but > I think developers should be capable of running any tool out there. If > someone is only able to build with Maven and nothing else I'm not sure they > should be running Guice trunk or submitting patches back to Guice. But > that's merely my opinion. > hmm, personally I look at the patches and not the developer All that said, as long as there are targets that create the Maven artifacts, > it will still work the exact same way that Maven does. In the end, all Maven > is doing is making JARs, XML and copying them to the correct places. > sure, all we're doing here is enabling people to build with ant or maven - then they can decide which one to use > > > IDEs Maven support is generally for Maven central and local repositories. >> It doesn't compile local projects unless they are sub-projects. I have to >> say again that you can integrate with your Maven project without changing >> Guice's build to Maven. If the maintainers don't want to use Maven, it is >> simple for them to provide integration hooks without major changes to their >> build or directory layout. Maven integration merely requires JARs and an XML >> file. >> > > sorry to be blunt, but I'll believe it when I see it - as others have > mentioned there are issues that have been open for a long time asking for > the extensions, sources, and javadoc, etc. to be uploaded to Maven central. > Not to mention regular snapshots that people could try to verify fixes > before the next release. > > > Feel free to be blunt, I obviously am. I'm just trying to be pragmatic with > this. I don't think asking the Guice project to change their build tool is > pragmatic if we can get it working with Maven simply by adding a new > target. > this is not a request to drop ant, just a request to move some directories around > The issue you are being blunt about isn't the build system, but the > distribution of artifacts. If the artifacts are available in Maven central > and easily build and installed locally, you should be fine and Guice doesn't > need to be built with Maven. > > > > so if someone has a patch to add such distribution targets (or the time to > write one) please submit it, then at least people have a way to do it > themselves > > > I could probably whip these up quickly. The POM structure is verbose, but > simple and the targets will just depend on the jar target and then copy the > files into the m2 local cache. > FYI, the main things needed when preparing a release for maven central are: pom, main jar, source jar, javadoc jar, plus signatures https://docs.sonatype.org/display/Repository/Uploading+3rd-party+Artifacts+to+Maven+Central also http://maven.apache.org/ant-tasks/index.html might save you some time -bp > > -- > You received this message because you are subscribed to the Google Groups > "google-guice" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<google-guice%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/google-guice?hl=en. > -- Cheers, Stuart -- You received this message because you are subscribed to the Google Groups "google-guice" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/google-guice?hl=en.
