The failure that's occurring is very similar to the problem described in #864. The assumptions of the test or the code we are testing is wrong. I don't feel comfortable adding a lot of conditional code in the test when we already know it is broken.
On Wed, Sep 10, 2008 at 1:28 PM, Kelly Norton <[EMAIL PROTECTED]> wrote: > Have you considered disabling those tests only for the platforms where they > are flaky? > /kel > > On Wed, Sep 10, 2008 at 1:26 PM, John LaBanca <[EMAIL PROTECTED]> wrote: > >> If we already comment out some methods, then LGTM. Joel doesn't think it >> matters, and I just wanted to be consistent not realizing that we've already >> used both comments and "disabled" methods. >> >> Thanks, >> John LaBanca >> [EMAIL PROTECTED] >> >> >> On Wed, Sep 10, 2008 at 1:19 PM, Eric Ayers <[EMAIL PROTECTED]> wrote: >> >>> I don't mind doing that. There are several other methods in ImageTest >>> commented out in the same way I did it. Want me to do the same for those? >>> >>> >>> On Wed, Sep 10, 2008 at 1:13 PM, John LaBanca <[EMAIL PROTECTED]>wrote: >>> >>>> I think we usually just rename the test to "disabledTestXXX" so JUnit >>>> doesn't run it. Do you mind doing it that way instead, but leaving the >>>> comment? Otherwise, the next time somebody auto-formats, the method will >>>> be >>>> formatted like a comment. >>>> >>>> Thanks, >>>> John LaBanca >>>> [EMAIL PROTECTED] >>>> >>>> >>>> >>>> On Wed, Sep 10, 2008 at 1:10 PM, Eric Ayers <[EMAIL PROTECTED]> wrote: >>>> >>>>> Hello John, >>>>> >>>>> I would like for you to review this patch. >>>>> >>>>> The testChangeClippedImageToUnclipped() method fails intermittently in >>>>> our continuous build system on Linux hosted mode. This could be related >>>>> to >>>>> issues 863 & 864 >>>>> >>>>> http://code.google.com/p/google-web-toolkit/issues/detail?id=863 >>>>> http://code.google.com/p/google-web-toolkit/issues/detail?id=864 >>>>> >>>>> I've commented out the test, as there are many other tests in this >>>>> TestCase that are commented out due to the same issues. >>>>> >>>>> M user/test/com/google/gwt/user/client/ui/ImageTest.java >>>>> >>>>> -- >>>>> Eric Z. Ayers - GWT Team - Atlanta, GA USA >>>>> http://code.google.com/webtoolkit/ >>>>> >>>> >>>> >>> >>> >>> -- >>> Eric Z. Ayers - GWT Team - Atlanta, GA USA >>> http://code.google.com/webtoolkit/ >>> >> >> >> >> >> > > > -- > If you received this communication by mistake, you are entitled to one free > ice cream cone on me. Simply print out this email including all relevant > SMTP headers and present them at my desk to claim your creamy treat. We'll > have a laugh at my emailing incompetence, and play a game of ping pong. > (offer may not be valid in all States). > -- Eric Z. Ayers - GWT Team - Atlanta, GA USA http://code.google.com/webtoolkit/ --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
