LGTM. Before you commit, though, can anyone think of a single case where a hyphen would legitimately be used here? I can't, and as John points out, even stuff like "-moz-opacity" doesn't use a hyphen in this context.
On Wed, Sep 17, 2008 at 12:23 PM, John LaBanca <[EMAIL PROTECTED]> wrote: > Joel - > > Please do a code review for this Style enhancement. > > Description: > ======== > When setting style properties programatically in GWT, it would be nice to > assert that the styles do not contain hyphens so people don't accidently use > names like "margin-left" instead of "marginLeft". > > > Fix: > === > This patch adds an assertion that the property name for all Style methods > is in camelCase format. I verified that when assertions are disabled, the > code will be completely compiled out. I also verified that mozilla > extensions follow the camelCase rule (eg. "-moz-opacity" should be > "MozOpacity"). > > > Testing: > ====== > I verified this in hosted and web mode on FF and added a unit test. > > > Thanks, > John LaBanca > [EMAIL PROTECTED] > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
