Thank you! Committed as r1093. On Mon, Oct 6, 2008 at 9:36 AM, Emily Crutcher <[EMAIL PROTECTED]> wrote:
> As you've proven your ability (several times now) to produce tight good > code, I've added you as a gwt-incubator committer, so you should be able to > commit it yourself > > > > > On Mon, Oct 6, 2008 at 9:07 AM, Isaac Truett <[EMAIL PROTECTED]> wrote: > >> Good enough to commit it for me? :) >> >> >> On Sat, Oct 4, 2008 at 10:33 AM, Emily Crutcher <[EMAIL PROTECTED]> wrote: >> >>> LGTM >>> >>> >>> On Fri, Oct 3, 2008 at 9:16 PM, Isaac Truett <[EMAIL PROTECTED]> wrote: >>> >>>> Oops. My *other* datepicker, right. >>>> Here's the new patch with gen2 datepicker and implementing HasValue on >>>> DropDownListBox instead of CustomListBox. >>>> >>>> Thanks, >>>> Isaac >>>> >>>> On Fri, Oct 3, 2008 at 6:21 PM, Emily Crutcher <[EMAIL PROTECTED]> wrote: >>>> >>>>> I like the feel of it, can you patch against the gen2 datepicker >>>>> though? Also, I think we might want to move the HasValue interface from >>>>> CustomListBox to DropDownListBox, as we plan to eventually have a >>>>> MultiSelectListBox and therefore, we might want to keep our options open. >>>>> >>>>> >>>>> On Fri, Oct 3, 2008 at 5:43 PM, Isaac Truett <[EMAIL PROTECTED]>wrote: >>>>> >>>>>> I originally proposed a HasValue interface in this >>>>>> thread<http://groups.google.com/group/Google-Web-Toolkit-Contributors/browse_thread/thread/b696e7319fc6bea>. >>>>>> Although the discussion largely focused on data binding, HasValue is not >>>>>> an >>>>>> attempt at a data binding library. The HasValue concept is more about >>>>>> providing a common API for many Widgets and other Objects that have a >>>>>> distinct logical value. This is conceptually the same as HasText, but >>>>>> parameterized to allow for data types other than String. >>>>>> The attached patch to the Incubator trunk includes the HasValue >>>>>> interface and implements this interface in DropDownListBox and >>>>>> DatePicker. >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> "There are only 10 types of people in the world: Those who understand >>>>> binary, and those who don't" >>>>> >>>>> >>>>> >>>> >>>> >>>> >>> >>> >>> -- >>> "There are only 10 types of people in the world: Those who understand >>> binary, and those who don't" >>> >>> >>> >> >> >> > > > -- > "There are only 10 types of people in the world: Those who understand > binary, and those who don't" > > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
