LGTM. Minor: In Pruner, it strikes me that you shouldn't have to do this. Perhaps most of the code in visit(JMethodCall) should be moved into visit(JMethod)
BTW: your patch name is teh lolz. :) Scott On Thu, Oct 9, 2008 at 6:25 PM, Lex Spoon <[EMAIL PROTECTED]> wrote: > Thanks, Scott. > The patch should apply to trunk. Would you mind it going into trunk if it > looks good? I'll merge it over to the runAsync branch the next time I sync > it with trunk. > > The linear search you point at does not look so good on closer inspection. > For each method in the program, there is a linear search through all the > *entry* methods of the program. That's okay right now, but if there are ever > a lot of entry methods, it could get expensive. > > Attached is an update that is just like the previous one, but it replaces > the linear scan by a lookup in an IdentityHashMap. > > -Lex > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
