On Mon, Oct 27, 2008 at 4:22 PM, Ray Ryan <[EMAIL PROTECTED]> wrote: > ** KeyGenerator.java:191 > > Shouldn't you be recursively checking all superclasses? Hmm. Actually, > since these things are interfaces, why check super at all? >
You can theoretically have your own concrete implementation for a particular locale, ie MyMessages_en could be a class implementing MyMessages and would be used for the en locale, though I am not sure why you would want to do that (the facility is there for other Localizable subclasses and is used by CldrImpl for example). Not sure if that is needed here, though future generators might want the facility for finding annotations on classes -- would it be better to split that out and put it in a utility class? Or if we leave it just for AnnotationResource, remove the super check? ** CommonInterfaceAnnotations.java:22 > > Nit: need <p> to break up 'graphs in javadoc > Thanks. -- John A. Tamplin Software Engineer (GWT), Google --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
