When you're right, you're right. I really can't justify the breaking change. I've switched the default to maintain status quo, so this change is now purely a new method. Submitted to 1.6 as r3873.
rjrjr On Thu, Oct 16, 2008 at 1:31 PM, Isaac Truett <[EMAIL PROTECTED]> wrote: > The Google home page? Is that really a factor in this decision? I'm honestly > surprised. Should we expect hosted mode to reject HTML pages with more than > 28 words by default? I mean, what's good for the Google home page... or were > you being facetious? > I only see one complainer in issue 2330. If you count comments in the > unrelated issue 1047 you have three, one of whom had a viable workaround. I > saw nothing to indicate that the default behavior had to change. An option > would be sufficient. > > Where's the overwhelming call for a breaking change? > > On Thu, Oct 16, 2008 at 1:15 PM, Ray Ryan <[EMAIL PROTECTED]> wrote: >> >> The patch responds to a number of complaints from folks who found the >> default behavior surprising. >> >> Normally I'm all about the conservatism, but what tips it for me in >> this case is that the thing is called a SuggestBox, in a package >> called the Google Web Toolkit. To me the principal of least >> astonishment says it should act like, you know, the famous Google >> Suggest Box widget on the Google home page. >> >> rjrjr >> >> On Thu, Oct 16, 2008 at 10:06 AM, Isaac Truett <[EMAIL PROTECTED]> wrote: >> > I agree that precedent can be found for either side. If you want an >> > example >> > from a web site, there's the "to" field in Gmail. I'm sure you have >> > another >> > counter example and we could continue this exchange (might actually be >> > fun, >> > but we should probably do it off-list). I think choosing the appropriate >> > behavior is up to the developer. In some situations you want to steer >> > users >> > towards suggestions and in other situations you don't. I doubt I would >> > be >> > surprised by either behavior. Is there an explicit doctrine in place to >> > favor protecting less stoic developers over preserving existing >> > applications? If this were a new Widget, I would see this point as >> > merely a >> > nitpick. For a published Widget, however, I think a more conservative >> > approach is desirable. >> > >> > >> > On Thu, Oct 16, 2008 at 12:45 PM, Ray Ryan <[EMAIL PROTECTED]> wrote: >> >> >> >> But if you compare the suggest box to its peers on actual web pages >> >> (especially including our own), you'll find they don't do this auto >> >> select thing. I think the current behavior is more surprising than the >> >> new behavior, and warrants the break. >> >> >> >> rjrjr >> >> >> >> On Thu, Oct 16, 2008 at 5:24 AM, Isaac Truett <[EMAIL PROTECTED]> >> >> wrote: >> >> > Can we reconsider the default setting? If you want a precedent for >> >> > automatically selecting the first suggestion, try Chrome. When I type >> >> > "mail" >> >> > into the omni bar, it automatically comes up with the first >> >> > suggestion, >> >> > "mail.google.com/mail," preselected. >> >> > Adding a switch is a great idea but is doing so with a breaking >> >> > change >> >> > really necessary? >> >> > >> >> > >> >> > On Wed, Oct 15, 2008 at 5:51 PM, Ray Ryan <[EMAIL PROTECTED]> wrote: >> >> >> >> >> >> This >> >> >> addresses >> >> >> http://code.google.com/p/google-web-toolkit/issues/detail?id=2330 >> >> >> The SuggestBox will no longer select its first item by default. In >> >> >> case >> >> >> there are existing apps that prefer this behavior, a boolean >> >> >> property >> >> >> (selectsFirstItem) is added to turn it back on. >> >> >> rjrjr >> >> >> >> >> >> >> >> > >> >> > >> >> > > >> >> > >> >> >> >> >> > >> > >> > > >> > >> >> > > > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
