I did a partial review of this branch in a clean trunk copy:
svn up -r3772
svn merge -r3772:3939
http://google-web-toolkit.googlecode.com/svn/changes/bobv/soyc-reports-r3772.
Still needs review (kprobst+spoon): *.soyc.*, dev.jjs, and dev.js packages
Here's my feedback on the parts I reviewed:
- StandanrdLinkerContext
- do we really want to bump link log level?
- SyntheticArtifact
- won't serialize properly across processes (delete on exit)
- ModuleDefLoader
- needs revert
- GWTCompiler
- needs revert
- possible rework to make sure GC can happen correctly: JJS must be
GC'd before linking
- PermutationCompiler
- will need manual merge
- package-info.java
- needs a @com.google.gwt.util.PreventSpuriousRebuilds annotation
- StandardCompilationAnalysis
- this class should use a Builder pattern, seriously
- It's actually incorrect as-is since many of the fields need to be
marked transient (everything but cacheFile I think!)
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
