>
>
>
> -------------------------------------------------------------------------------
> At lunch, we talked about introducing a GwtEvent here instead of an
> AbstractEvent. My primary objection is that AbstractX tends to suggest that
> you are using the inheritance chain to pull in shared implementation. The
> inheritance chain should really be used for decisions about assignability
> only, not code sharing. We've had many nightmares of inflexible classes and
> subclasses having to implement bogus methods in the past because of this.
> In this case, I think AbstractEvent really is a common class for
> assignment, we just needed a better name. Are you still ok with that?
I think that change was actually committed last night, will have to check.
>
>
> Line 82: DomEvent<HandlerType> cached) {
>
> -------------------------------------------------------------------------------
> Should we work out that registration while this thing is in the 1.6 branch
> so that we don't have to release and then deprecate the constructor?
I really want to get off this branch, so if this ends up being the last
thing, we can make it package protected and call it from the two places that
need it.
>
>
> Line 195: this.nativeEvent = nativeEvent;
>
> -------------------------------------------------------------------------------
> Ah, that makes sense.
>
> Line 207: protected abstract DomEvent.Type<H> getAssociatedType();
>
> -------------------------------------------------------------------------------
> This class is abstract and getAssociatedType is abstract. This class
> doesn't do anything but redeclare that getAssociatedType is abstract. That
> was already given by the fact that it subclasses AbstractEvent. If I'm not
> misreading anything, removing this declaration will not produce an error or
> change anything at all.
It changes the return type from GwtEvent.Type to DomEvent.Type.
>
>
> Respond to these comments at
>
> http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083&branch=%2Fbranches%2F1_6_clean_events
> --
> You received this message because you starred this review, or because
> your project has directed all notifications to a mailing list that you
> subscribe to.
> You may adjust your review notification preferences at:
> http://code.google.com/hosting/settings
>
> >
>
--
"There are only 10 types of people in the world: Those who understand
binary, and those who don't"
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
