Author: [EMAIL PROTECTED] Date: Wed Nov 12 20:10:14 2008 New Revision: 4044
Modified: branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/BeforeSelectionEvent.java branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/ResizeEvent.java branches/1_6_clean_events/user/test/com/google/gwt/event/logical/shared/LogicalEventsTest.java Log: Fix uncompilable LogicalEvents test, style error in ResizeEvent, javadoc in BeforeSelectionEvent Modified: branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/BeforeSelectionEvent.java ============================================================================== --- branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/BeforeSelectionEvent.java (original) +++ branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/BeforeSelectionEvent.java Wed Nov 12 20:10:14 2008 @@ -39,7 +39,8 @@ * @param <S> The event source type * @param source the source of the handlers * @param item the item - * @return the event so that the caller can check if it was canceled + * @return the event so that the caller can check if it was canceled, or null + * if no handlers of this event type have been registered */ public static <I, S extends HasBeforeSelectionHandlers<I> & HasHandlers> BeforeSelectionEvent<I> fire( S source, I item) { Modified: branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/ResizeEvent.java ============================================================================== --- branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/ResizeEvent.java (original) +++ branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/ResizeEvent.java Wed Nov 12 20:10:14 2008 @@ -63,8 +63,6 @@ private final int width; private final int height; - - /** * Construct a new [EMAIL PROTECTED] ResizeEvent}. * Modified: branches/1_6_clean_events/user/test/com/google/gwt/event/logical/shared/LogicalEventsTest.java ============================================================================== --- branches/1_6_clean_events/user/test/com/google/gwt/event/logical/shared/LogicalEventsTest.java (original) +++ branches/1_6_clean_events/user/test/com/google/gwt/event/logical/shared/LogicalEventsTest.java Wed Nov 12 20:10:14 2008 @@ -15,8 +15,8 @@ */ package com.google.gwt.event.logical.shared; -import com.google.gwt.event.shared.GwtEvent; import com.google.gwt.event.shared.EventHandler; +import com.google.gwt.event.shared.GwtEvent; import com.google.gwt.event.shared.HandlerManager; import junit.framework.TestCase; @@ -69,7 +69,7 @@ simpleFire(SelectionEvent.getType(), new SelectionEvent<String>()); simpleFire(CloseEvent.getType(), new CloseEvent<String>()); simpleFire(OpenEvent.getType(), new OpenEvent<String>()); - simpleFire(ResizeEvent.getType(), new ResizeEvent()); + simpleFire(ResizeEvent.getType(), new ResizeEvent(0, 0)); simpleFire(ValueChangeEvent.getType(), new ValueChangeEvent<String>()); } --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---