[google-web-toolkit] [EMAIL PROTECTED] commented on revision r4138. Details are at http://code.google.com/p/google-web-toolkit/source/detail?r=4138
Score: Neutral General Comment: Typos here, need to delete "view" from both lines hee hee, eclipse auto-renaming can be fun! should be calling getView() throughout, especially since it's protected. Sometimes you do, sometimes you don't. Otherwise should make the method final. Both getView() and getMonthSelector() are final actually, and yep, I have that on my list, trying to keep the review burden down for individual commits. This one was for finals and renaming only. Respond to these comments at http://code.google.com/p/google-web-toolkit/source/detail?r=4138 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
