Reviewers: rjrjr, Message: LGTM with the nits below fixed.
http://codereview.appspot.com/8700/diff/1/3 File user/src/com/google/gwt/user/client/ui/Hyperlink.java (right): http://codereview.appspot.com/8700/diff/1/3#newcode45 Line 45: * <h3>CSS Style Rules</h3> <ul class='css'> <li>.gwt-Hyperlink { }</li> </ul> Autoformat damage. Please don't autoformat entire existing classes. http://codereview.appspot.com/8700/diff/1/3#newcode56 Line 56: private Element anchorElem; can you make this final? http://codereview.appspot.com/8700/diff/1/2 File user/src/com/google/gwt/user/client/ui/InlineHyperlink.java (right): http://codereview.appspot.com/8700/diff/1/2#newcode25 Line 25: * <h3>CSS Style Rules</h3> <ul class='css'> <li>.gwt-InlineHyperlink { }</li> shouldn't be in one line http://codereview.appspot.com/8700/diff/1/2#newcode64 Line 64: public InlineHyperlink(String text, String targetHistoryToken) { I'd expect this to be this(text, false, targetHistoryToken); Description: Hello Ray :) Would you take a look at this patch for the 1.6 branch, adding the InlineHyperlink widget? It adds a protected constructor to Hyperlink, allowing subclasses to pass a wrapper element. If that element is null, it calls setElement with the anchor element. InlineHyperlink then is just a Hyperlink widget with no wrapping div. Associated issue is here: http://code.google.com/p/google-web-toolkit/issues/detail?id=3056 Thanks! -- Alex Rudnick swe, gwt, atl Please review this at http://codereview.appspot.com/8700 Affected files: user/src/com/google/gwt/user/client/ui/Hyperlink.java user/src/com/google/gwt/user/client/ui/InlineHyperlink.java --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
