Make that r4250 + r4251; I forgot to commit the calling code in StandardGeneratorContext.
On Thu, Dec 4, 2008 at 1:46 PM, Scott Blum <[EMAIL PROTECTED]> wrote: > Looks great, I went ahead and committed at r4250. I actually tweaked > StandardGeneratedResource such that the constructor takes a File instead of > a URL, which simplifies the calling code and allows a simple > file.lastModified() implementation. Please make sure my tweak is sane. > > > On Thu, Dec 4, 2008 at 1:08 PM, Scott Blum <[EMAIL PROTECTED]> wrote: > >> I can take this review. >> >> >> On Thu, Dec 4, 2008 at 10:56 AM, BobV <[EMAIL PROTECTED]> wrote: >> >>> The attached patch against the 1.6 branch adds >>> EmittedArtifact.getLastModified() which is used to set the mtime on >>> files written to disk by the compiler. This resolves issue 2280. >>> >>> The default implementation in the EmittedArtifact base class is >>> concrete to avoid breaking changes and always returns the current >>> time, which is consistent with the previous behavior. >>> >>> diffstat: >>> EmittedArtifact.java | 24 19 + 5 - 0 ! >>> SyntheticArtifact.java | 6 6 + 0 - 0 ! >>> impl/StandardGeneratedResource.java | 6 6 + 0 - 0 ! >>> impl/StandardLinkerContext.java | 1 1 + 0 - 0 ! >>> impl/StandardPublicResource.java | 18 16 + 2 - 0 ! >>> 5 files changed, 48 insertions(+), 7 deletions(-) >>> >>> -- >>> Bob Vawter >>> Google Web Toolkit Team >>> >>> >>> >>> >> > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
