Submitted; the ant dependency would explain why the builds succeeded.... On Tue, Dec 9, 2008 at 4:27 PM, Amit Manjhi <[EMAIL PROTECTED]> wrote:
> LGTM. > > I had to make this change myself. (Apparently, this does not happen with > ant 1.7+) > > > On Tue, Dec 9, 2008 at 11:55 AM, Freeland Abbott < > [EMAIL PROTECTED]> wrote: > >> Another patch-review for you, sorry: I'm actually a bit surprised that the >> prior built, which it did, but I just got a local build error complaining >> about <tarfileset> occurring inside a <zip> for the windows build... dangers >> of too much cut-n-paste. >> >> Patch in-line, as it's so short: >> >> >> Index: distro-source/windows/build.xml >> =================================================================== >> --- distro-source/windows/build.xml (revision 4279) >> +++ distro-source/windows/build.xml (working copy) >> @@ -13,7 +13,7 @@ >> <zipfileset file="${gwt.build.lib}/gwt-user.jar" >> prefix="${project.distname}" /> >> <zipfileset file="${gwt.build.lib}/gwt-servlet.jar" >> prefix="${project.distname}" /> >> <zipfileset file="${gwt.build.lib}/gwt-benchmark-viewer.jar" >> prefix="${project.distname}" /> >> - <tarfileset file="${gwt.build.lib}/gwt-soyc-vis.jar" >> prefix="${project.distname}" /> >> + <zipfileset file="${gwt.build.lib}/gwt-soyc-vis.jar" >> prefix="${project.distname}" /> >> >> <!-- jni libs--> >> <zipfileset dir="${gwt.build.jni}/${dist.platform}" >> prefix="${project.distname}" /> >> >> >> >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---