dev/core/src/com/google/gwt/core/ext/linker/AbstractLinker.java
      |   71    70 +    1 -     0 !

What's with the @SuppressWarnings tags?

 dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java
|   20  13 +    7 -     0 !

emitSelectionScript(): add a comment to explain logic
L233: break string literal

 dev/core/src/com/google/gwt/core/ext/linker/impl/StandardLinkerContext.java
|   18  11 +    7 -     0 !

Constructor: That one-liner comment was intended to prevent the reader
from wondering when generated artifacts are included in the SLC.
produceOutputDirectory(): Should that be a <= instead of < ?

 dev/core/src/com/google/gwt/core/linker/IFrameLinker.java
      |   36    32 +    4 -     0 !

Extract a URLArtifact type?

 dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js
      |   22    16 +    6 -     0 !

isHostedMode(): Cute.

 dev/core/src/com/google/gwt/dev/GWTCompiler.java
      |   24    21 +    3 -     0 !
 dev/core/src/com/google/gwt/dev/GWTShell.java
      |   24    21 +    3 -     0 !

Use JavaDoc @deprecated and add a WARN message to indicate that these
entrypoints will be removed.

 dev/core/src/com/google/gwt/dev/HostedMode.java
      |  168    120 +   48 -    0 !

link() and relink() have the same JavaDoc comments.
Suggest moving the computation of moduleOutDir and moduleExtraDir into
a utility function, since this gets repeated in several places.

 dev/core/src/com/google/gwt/dev/HostedModeBase.java
      |   83    57 +    26 -    0 !

Document refresh param on loadModule()

 dev/core/src/com/google/gwt/dev/shell/BrowserWidget.java
      |   72    39 +    33 -    0 !

Update EXPECTED_GWT_ONLOAD_VERSION?

-- 
Bob Vawter
Google Web Toolkit Team

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to