Thanks Bob and Freeland. I should have mentioned that the current about.txt is just a placeholder and I was planning to work with Emily to fix it up later. I will remember to update the copyright and include the licensing info. I also forgot to activate checkstyle for gwt-incubator. Will fix those errors.
Regarding how to implement the SvnInfo command and where the code should reside, let us discuss the options today in person. Regards, Amit On Wed, Dec 10, 2008 at 11:20 PM, Freeland Abbott < [EMAIL PROTECTED]> wrote: > > 1. Your SvnInfo is different than the similarly-named one in gwt... > that's likely to be confusing. > 1. If we're going to use SvnInfo in both gwt and gwt-incubator, we > should probably move it into the (also shared) tools project, presumably > under tools/antlib, and they should be the same. If not, they should > have > different names. > 2. I'm mildly concerned that your take is very specific; it updates > one file (by hardcoded name) and that's all. Which is, granted, all you > need here, but the fact that my cut exports the properties to do with > what > you will (in our case, pass to an ant Filter) is, IMHO, nice > general-purpose-ness. > 2. About.txt should either go away (and you can just System.println the > two strings you need), or become large enough to be worthwhile, probably by > inserting both copyright and license info. > 1. Regardless of where, we probably should have license info in the > distro! > 2. At present, it seems we include JavaSWF-License.txt in the jar, > but nothing about incubator > > > On Wed, Dec 10, 2008 at 7:04 PM, BobV <[EMAIL PROTECTED]> wrote: > >> about.txt >> - Wrong copyright. >> >> IncubatorMain: >> Do you have checkstyle working in your IDE? The sort-order and >> keyword ordering of your class variables are wrong. >> >> SvnInfo.java: >> Multiline comments should use /**/ >> Inconsistent order in variable keywords. >> >> -- >> Bob Vawter >> Google Web Toolkit Team >> > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
