Freeland -

Please do a code review on this patch that fixes the windows distro build
file.

Description:
=========
<zip> does not support the <tarfileset>, at least on my machine.  This looks
like a typo,

Fix:
===
Changed <tarfileset> to <zipfileset>, which is consistent with the rest of
the file.

Testing:
======
Building using "ant" now works.


Thanks,
John LaBanca
[EMAIL PROTECTED]

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Index: distro-source/windows/build.xml
===================================================================
--- distro-source/windows/build.xml	(revision 4304)
+++ distro-source/windows/build.xml	(working copy)
@@ -13,7 +13,7 @@
       <zipfileset file="${gwt.build.lib}/gwt-user.jar" prefix="${project.distname}" />
       <zipfileset file="${gwt.build.lib}/gwt-servlet.jar" prefix="${project.distname}" />
       <zipfileset file="${gwt.build.lib}/gwt-benchmark-viewer.jar" prefix="${project.distname}" />
-      <tarfileset file="${gwt.build.lib}/gwt-soyc-vis.jar" prefix="${project.distname}" />
+      <zipfileset file="${gwt.build.lib}/gwt-soyc-vis.jar" prefix="${project.distname}" />
 
       <!-- jni libs-->
       <zipfileset dir="${gwt.build.jni}/${dist.platform}" prefix="${project.distname}" />

Reply via email to