[+ contrib] Rietveld tip: If you give the issue title the same name as your RR thread's subject line, gmail will group them together. For that matter, you could have sent the RR message from Rietveld.
rjrjr On Thu, Dec 18, 2008 at 9:41 AM, <rj...@google.com> wrote: > This is big improvement. I think Format should not need a pointer back > to its DateBox, though. Details inline. > > > http://gwt-code-reviews.appspot.com/1201/diff/1/2 > File > > reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForDateBox.java > (right): > > http://gwt-code-reviews.appspot.com/1201/diff/1/2#newcode112 > Line 112: startText.addKeyDownHandler(new KeyDownHandler() { > This code had been removed because of bugs in insertion point placement. > Have they been fixed? > > http://gwt-code-reviews.appspot.com/1201/diff/1/3 > File user/src/com/google/gwt/user/datepicker/client/DateBox.java > (right): > > http://gwt-code-reviews.appspot.com/1201/diff/1/3#newcode102 > Line 102: * > extra empty line > > http://gwt-code-reviews.appspot.com/1201/diff/1/3#newcode117 > Line 117: * Gets the date box associated with this format. > perhaps you can put it here instead. :-) > > http://gwt-code-reviews.appspot.com/1201/diff/1/3#newcode140 > Line 140: assert dateBox == null : "DateBox.DefaultFormat can only > format one date box"; > The dateBox field seems wrong, you don't need the circular relationship > btw. DateBox and format. Instead, why don't you pass in the dateBox as a > param to format, parse and reset--and allow yourself to share instances? > Then you can get rid of this init method entirely. > > http://gwt-code-reviews.appspot.com/1201 > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
