This seems like the right model of behavior. I wonder if we could figure out
a way to tweak the API exposing the behavior though when you get back from
vacation? As a user, I think I might get confused by the interactions of
setAlwaysAutoHide(), setAutoHidePartner,
setAutoHide(true/false),isAutoHideEnabled(), and isAlwaysAutoHide(), so I'm
hoping there is a way to represent the same information with fewer moving
parts.
Cheers,
Emily
On Mon, Dec 22, 2008 at 12:46 PM, <jlaba...@google.com> wrote:
> Reviewers: ecc,
>
> Description:
> The latest version of this patch introduces
> PopupPanel.setAlwaysAutoHide(). Unlike autoHide, alwaysAutoHide
> indicates that the PopupPanel should autoHide even if it isn't at the
> top of the stack. The only time it does not autoHide is if a modal
> popup is open above it.
>
> We have also gone back to NativePreviewEvent.cancel()/consume().
>
> Both the SuggestBox and MenuBar setAlwaysAutoHide to true. However, the
> MenuBar overrides the event preview to handle all of its unique special
> cases.
>
> Please review this at http://gwt-code-reviews.appspot.com/1801
>
> Affected files:
>
>
> reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/Issue1932.java
>
>
> reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForDialogBox.java
> user/src/com/google/gwt/event/dom/client/DomEvent.java
> user/src/com/google/gwt/event/dom/client/HasNativeEvent.java
> user/src/com/google/gwt/event/shared/GwtEvent.java
> user/src/com/google/gwt/event/shared/HandlerManager.java
> user/src/com/google/gwt/user/client/DOM.java
> user/src/com/google/gwt/user/client/Event.java
> user/src/com/google/gwt/user/client/EventPreview.java
> user/src/com/google/gwt/user/client/ui/DialogBox.java
> user/src/com/google/gwt/user/client/ui/MenuBar.java
> user/src/com/google/gwt/user/client/ui/PopupPanel.java
> user/src/com/google/gwt/user/client/ui/SuggestBox.java
> user/test/com/google/gwt/user/UISuite.java
> user/test/com/google/gwt/user/client/EventTest.java
> user/test/com/google/gwt/user/client/ui/PopupTest.java
>
>
>
--
"There are only 10 types of people in the world: Those who understand
binary, and those who don't"
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
