[gwt-contrib] [google-web-toolkit commit] r4393 - releases/1.6/user/src/com/google/gwt/user/client/ui

[codesite-noreply]

Author: jlaba...@google.com
Date: Wed Jan  7 08:42:41 2009
New Revision: 4393

Modified:
    releases/1.6/user/src/com/google/gwt/user/client/ui/TabListener.java
    releases/1.6/user/src/com/google/gwt/user/client/ui/TabPanel.java

Log:
Removed TabPanel#onBeforeSelection and TabPanel#onSelection for the API.   
We do not want to provide hooks for events when we already provide Event  
Handlers for them.

Patch by: jlabanca
Review by: ecc
Issue: 3235



Modified:  
releases/1.6/user/src/com/google/gwt/user/client/ui/TabListener.java
==============================================================================
--- releases/1.6/user/src/com/google/gwt/user/client/ui/TabListener.java        
 
(original)
+++ releases/1.6/user/src/com/google/gwt/user/client/ui/TabListener.java        
 
Wed Jan  7 08:42:41 2009
@@ -33,6 +33,9 @@
     * @param tabIndex the index of the tab about to be selected
     * @return <code>false</code> to disallow the selection. If any listener
     *         returns false, then the selection will be disallowed.
+   * @deprecated use
+   *             {...@link  
TabPanel#addBeforeSelectionHandler(com.google.gwt.event.logical.shared.BeforeSelectionHandler)}
+   *             instead
     */
    @Deprecated
    boolean onBeforeTabSelected(SourcesTabEvents sender, int tabIndex);
@@ -42,6 +45,9 @@
     *
     * @param sender the {...@link TabBar} or {...@link TabPanel} whose tab was 
 
selected
     * @param tabIndex the index of the tab that was selected
+   * @deprecated use
+   *             {...@link  
TabPanel#addSelectionHandler(com.google.gwt.event.logical.shared.SelectionHandler)}
+   *             instead
     */
    @Deprecated
    void onTabSelected(SourcesTabEvents sender, int tabIndex);

Modified: releases/1.6/user/src/com/google/gwt/user/client/ui/TabPanel.java
==============================================================================
--- releases/1.6/user/src/com/google/gwt/user/client/ui/TabPanel.java    
(original)
+++ releases/1.6/user/src/com/google/gwt/user/client/ui/TabPanel.java   Wed  
Jan  7 08:42:41 2009
@@ -354,20 +354,10 @@
      return deck.iterator();
    }

-  public void onBeforeSelection(BeforeSelectionEvent<Integer> event) {
-    if (!onBeforeTabSelected(tabBar, event.getItem().intValue())) {
-      event.cancel();
-    }
-  }
-
    @Deprecated
    public boolean onBeforeTabSelected(SourcesTabEvents sender, int  
tabIndex) {
      BeforeSelectionEvent<Integer> event = BeforeSelectionEvent.fire(this,  
tabIndex);
      return event == null || !event.isCanceled();
-  }
-
-  public void onSelection(SelectionEvent<Integer> event) {
-    onTabSelected(tabBar, event.getSelectedItem().intValue());
    }

    @Deprecated

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---