LGTM On Fri, Jan 9, 2009 at 11:53 AM, <jlaba...@google.com> wrote:
> Reviewers: ecc, > > Description: > The keyCode is a read only attribute in all browsers except IE. This > patch deprecates the setKeyCode method so we can remove it in a future > release. > > Here is the associated issue: > http://code.google.com/p/google-web-toolkit/issues/detail?id=25 > > Please review this at http://gwt-code-reviews.appspot.com/2002 > > Affected files: > user/src/com/google/gwt/user/client/DOM.java > user/src/com/google/gwt/user/client/ui/TextBoxBase.java > > > Index: user/src/com/google/gwt/user/client/DOM.java > =================================================================== > --- user/src/com/google/gwt/user/client/DOM.java (revision 4419) > +++ user/src/com/google/gwt/user/client/DOM.java (working copy) > @@ -626,7 +626,10 @@ > * > * @param evt the event whose key code is to be set > * @param key the new key code > + * @deprecated this method only works in IE and should not have been > added to > + * the API > */ > + @Deprecated > public static void eventSetKeyCode(Event evt, char key) { > impl.eventSetKeyCode(evt, key); > } > Index: user/src/com/google/gwt/user/client/ui/TextBoxBase.java > =================================================================== > --- user/src/com/google/gwt/user/client/ui/TextBoxBase.java (revision > 4419) > +++ user/src/com/google/gwt/user/client/ui/TextBoxBase.java (working > copy) > @@ -226,7 +226,10 @@ > * listeners to easily filter keyboard input. > * > * @param key the new key value > + * @deprecated this method only works in IE and should not have been > added to > + * the API > */ > + @Deprecated > public void setKey(char key) { > if (currentEvent != null) { > DOM.eventSetKeyCode(currentEvent, key); > > > -- "There are only 10 types of people in the world: Those who understand binary, and those who don't" --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
