Reviewers: scottb,

Description:
The JUnit infrastructure used to ignore unexpected, uncaught exceptions.
In practice this included exceptions thrown from event handlers that
were triggered synchronously from within the test method.

This patch deals with this by hanging onto the first "unexpected"
exception in the UncaughtExceptionHandler, and dealing with it when the
test method returns.

The reason I believe it is ok to only report the first exception is that
this is indistinguishable from a normal exception -- you'll normally
only ever see the first one. The only reason multiple exceptions even
*can* occur is that we can't force the test method to return immediately
after an unexpected exception occurs.

Please review this at http://gwt-code-reviews.appspot.com/2008

Affected files:
    
user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/GWTTestCase.java
   user/test/com/google/gwt/junit/client/TestManualAsync.java



--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to