Bob, could you review trunk/r4506? It was a trivial change to add a null
check arounjd starting the BrowserListener thread so that if an exception
occurred during initialization (which would be logged), an NPE prevented the
user from reading it. One common cause would be starting a second OOPHM
shell listening on the same port. Patch:
Index: dev/oophm/src/com/google/gwt/dev/shell/BrowserListener.java
===================================================================
--- dev/oophm/src/com/google/gwt/dev/shell/BrowserListener.java (revision
4496)
+++ dev/oophm/src/com/google/gwt/dev/shell/BrowserListener.java (working
copy)
@@ -98,6 +98,8 @@
}
public void start() {
- listenThread.start();
+ if (listenThread != null) {
+ listenThread.start();
+ }
}
}
--
John A. Tamplin
Software Engineer (GWT), Google
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
