These patches for 1.6 or trunk? It seems like we want to do this in 1.6, right?
On Fri, Feb 13, 2009 at 5:45 AM, Eric Ayers <zun...@google.com> wrote: > [crossposted to gwt-google-apis & google-web-toolkit-contrib] > > Well, my patch blows up in trunk builds because About.VERSION_NUM is > set to 0.0. > > Attached is a GWT patch that moves the > BrowserWidget.EXPECTED_GWT_ONLOAD_VERSION constant to > SelectionScriptLinker and performs a substitution. Also attached is a > gwt-google-apis patch so that the GadgetLinker will have a fallback > (for 1.6.0 and earlier versions) and just shove in "1.6" for now. > > -Eric. > > On Mon, Feb 2, 2009 at 4:30 PM, <b...@google.com> wrote: > > LGTM > > > > > > http://galgwt-reviews.appspot.com/3003/diff/1/2 > > File gadgets/src/com/google/gwt/gadgets/linker/GadgetLinker.java > > (right): > > > > http://galgwt-reviews.appspot.com/3003/diff/1/2#newcode127 > > Line 127: String gwtVersions[] = About.GWT_VERSION_NUM.split("\\."); > > This is technically derived from > > BrowserWidget.EXPECTED_GWT_ONLOAD_VERSION, but that's a private field. > > My expectation is that this will evolve in a manner similar to > > About.java, but it may be worthwhile to add a patch to make the expected > > version public. > > > > http://galgwt-reviews.appspot.com/3003 > > > > > > -- > Eric Z. Ayers - GWT Team - Atlanta, GA USA > http://code.google.com/webtoolkit/ > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
