I'm lovin' this tool.
http://gwt-code-reviews.appspot.com/4806/diff/1/5 File src-demo/com/google/gwt/gen2/demo/fasttree/FastTreeDemo.gwt.xml (left): http://gwt-code-reviews.appspot.com/4806/diff/1/5#oldcode2 Line 2: On 2009/02/13 21:01:40, ecc wrote: > looks like a line was lost. do you want it back? http://gwt-code-reviews.appspot.com/4806/diff/1/5 File src-demo/com/google/gwt/gen2/demo/fasttree/FastTreeDemo.gwt.xml (right): http://gwt-code-reviews.appspot.com/4806/diff/1/5#newcode7 Line 7: On 2009/02/13 21:01:40, ecc wrote: > Extra line. maybe this is line 2? ;) I like to have separation between comments, should I remove this line? http://gwt-code-reviews.appspot.com/4806/diff/1/6 File src-demo/com/google/gwt/gen2/demo/fasttree/client/FastTreeDemo.java (right): http://gwt-code-reviews.appspot.com/4806/diff/1/6#newcode201 Line 201: selectedItem.addItem("Dad"); On 2009/02/13 21:01:40, ecc wrote: > how about adding "John the " + xth + and " Jane the "xth" instead, where x is > the depth of the tree? how do i get the depth? http://gwt-code-reviews.appspot.com/4806/diff/1/6#newcode207 Line 207: On 2009/02/13 21:01:40, ecc wrote: > hee hee, that one's good :-). Might be better to say "disown" rather then "kill" > though, just in case. Done. http://gwt-code-reviews.appspot.com/4806/diff/1/2 File src/com/google/gwt/gen2/complexpanel/ComplexPanel.gwt.xml (right): http://gwt-code-reviews.appspot.com/4806/diff/1/2#newcode4 Line 4: <inherits name='com.google.gwt.gen2.widgetbase.WidgetBase' /> On 2009/02/13 21:01:40, ecc wrote: > Hmm... logging should be inherited in widget base, can you move it there? Done. http://gwt-code-reviews.appspot.com/4806/diff/1/4 File src/com/google/gwt/gen2/complexpanel/client/FastTree.java (right): http://gwt-code-reviews.appspot.com/4806/diff/1/4#newcode341 Line 341: * @return The 'root' item is invisible and serves only as a container for On 2009/02/13 21:01:40, ecc wrote: > Need to repeat the comment before the @return, as javadoc is not very smart at > presenting things to users at times. I just got rid of the @return, seems more efficient. http://gwt-code-reviews.appspot.com/4806/diff/1/4#newcode492 Line 492: protected FastTreeItem getRoot() { On 2009/02/13 21:01:40, ecc wrote: > this one should be deprecated, as it has been replaced by the public > getTreeRoot() I didn't even notice this was here... done. http://gwt-code-reviews.appspot.com/4806/diff/1/3 File src/com/google/gwt/gen2/complexpanel/client/HasFastTreeItems.java (right): http://gwt-code-reviews.appspot.com/4806/diff/1/3#newcode31 Line 31: * directly. On 2009/02/13 21:01:40, ecc wrote: > Might mention here that instead of using it, use getTreeRoot() to have a unified > way to crawl over the tree. Added, but not sure if it makes sense here. http://gwt-code-reviews.appspot.com/4806 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
