[gwt-contrib] [google-web-toolkit commit] r4817 - trunk/user/src/com/google/gwt/core/client/impl

[codesite-noreply]

Author: b...@google.com
Date: Fri Feb 20 04:53:55 2009
New Revision: 4817

Modified:
    trunk/user/src/com/google/gwt/core/client/impl/StackTraceCreator.java

Log:
Fix null derefenece in Mozilla browsers if we attempt to create a  
JavaScriptException after encountering a "throw null;" scenario.

Patch by: bobv
Review by: jgw (TBR)


Modified:  
trunk/user/src/com/google/gwt/core/client/impl/StackTraceCreator.java
==============================================================================
--- trunk/user/src/com/google/gwt/core/client/impl/StackTraceCreator.java       
 
(original)
+++ trunk/user/src/com/google/gwt/core/client/impl/StackTraceCreator.java       
 
Fri Feb 20 04:53:55 2009
@@ -112,7 +112,7 @@
      }

      protected native JsArrayString getStack(JavaScriptObject e) /*-{
-      return !!e.stack ? e.stack.split('\n') : [];
+      return (e && e.stack) ? e.stack.split('\n') : [];
      }-*/;

      protected int toSplice() {
@@ -160,7 +160,7 @@
      }

      private native JsArrayString getMessage(JavaScriptObject e) /*-{
-      return !!e.message ? e.message.split('\n') : [];
+      return (e && e.message) ? e.message.split('\n') : [];
      }-*/;

      private native void setLength(JsArrayString obj, int length) /*-{


--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---