On Tue, Mar 17, 2009 at 8:38 PM, Scott Blum <sco...@google.com> wrote:

> Looks good, with suggestions.  Attached is what I meant when I was talking
> about subclassing HostedModeBase.BrowserWidgetHostImpl.  This should remove
> some duplicate code.  This also brings HostedMode in OOPHM up to the
> present.  Apply my patch on top of yours.


I don't particularly like providing two overlapping APIs in
BrowserWIdgetHost, but I guess it is going to be ugly either way until we
dump legacy hosted mode.

Shall I commit it with your changes and doing the rest of the launch
configs?  I am not currently setup to test on Windows -- did you try the
launch config there?

-- 
John A. Tamplin
Software Engineer (GWT), Google

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to