Thanks, John!  It's in at r5094 and r5095.  Comments inline:

On Thu, Mar 26, 2009 at 4:31 PM, John Tamplin <j...@google.com> wrote:
> Passing the parameter all the way down this way is ugly, but I don't know of
> any better ways to do it.

Agreed.


> I would prefer the new ArgHandler to be a top-level class, but I see the
> others are inlined as well so I am ok with keeping it.

Also agreed, so I left it.

> I don't see the build.xml changes for test.noserver.

Shoot, that part of the patch got lost.  I recreated these per our discussion.


Lex

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to