LGTM. On Tue, Mar 31, 2009 at 8:02 PM, <b...@google.com> wrote:
> Reviewers: jat, scottb, > > Description: > This patch fixes a compiler exception relating to SingleJsoImpl types > that have array return types. The bug stems from the fact that > JArrayType extends JClassType, but JArrayType.isClass() returns null. > The fix is to add an explicit check for array types to > CompilingClassLoader.getBinaryOrPrimitiveName(). The SingleJsoImplTest > is also updated. > > Please review this at http://gwt-code-reviews.appspot.com/14804 > > Affected files: > dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java > user/test/com/google/gwt/dev/jjs/test/SingleJsoImplTest.java > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---