http://gwt-code-reviews.appspot.com/34811/diff/1/3
File user/super/com/google/gwt/emul/java/lang/String.java (right):

http://gwt-code-reviews.appspot.com/34811/diff/1/3#newcode133
Line 133: hashCode |= 0;
On 2009/05/15 15:10:36, robsonbraga wrote:
> I don't think you need to convert to 32 bits in every step, just at
the end.

The problem is for really long strings you can lose precision in the
double, and you will get a different result.

http://gwt-code-reviews.appspot.com/34811/diff/1/2
File user/test/com/google/gwt/emultest/java/lang/StringTest.java
(right):

http://gwt-code-reviews.appspot.com/34811/diff/1/2#newcode220
Line 220: savedHash[i] = testStrings[i].hashCode();
Just do the assertEquals here, and the assert message should contain the
string where the hashCode doesn't match.

http://gwt-code-reviews.appspot.com/34811

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to