LGTM, just some nits.

http://gwt-code-reviews.appspot.com/33835/diff/1/2
File
dev/core/src/com/google/gwt/core/ext/soyc/impl/StandardClassMember.java
(right):

http://gwt-code-reviews.appspot.com/33835/diff/1/2#newcode44
Line 44: private SortedSet<ClassMember> overridesView = null;
The explicit initialization isn't necessary.

http://gwt-code-reviews.appspot.com/33835/diff/1/2#newcode65
Line 65:
Whitespace.

http://gwt-code-reviews.appspot.com/33835/diff/1/2#newcode106
Line 106: // Compute overrides on demand
Use a javadoc-style comment here

http://gwt-code-reviews.appspot.com/33835

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to