Reviewers: scottb,

Message:
Requesting review

Description:
This patch would allow user-provided code to escape from the
CompilingClassLoader sandbox.

Use case:
   - Create a type that should be used only in hosted mode which lives
somewhere in the classpath
   - Create a web-mode implementation which lives in super-source
   - Annotate the web-mode implementation with the @BridgeClass
annotation

When CCL loads the super-source version it will notice the BridgeClass
annotation and load the (possibly binary-only) implementation of the
bridge class from the classpath via a child classloader.  This
newly-loaded type will then be able to refer to types that are not
defined in the CCL sandbox.

The web-mode compiler will continue to use the version in super-source
and ignore the BridgeClass annotation.

Please review this at http://gwt-code-reviews.appspot.com/34836

Affected files:
   M dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
   A dev/core/src/com/google/gwt/dev/shell/rewrite/HasAnnotation.java
   A dev/core/super/com/google/gwt/core/client/BridgeClass.java
   M user/build.xml
   A  
user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/bridge/UserBridgeClass.java
   M user/test/com/google/gwt/dev/jjs/CompilerSuite.java
   A user/test/com/google/gwt/dev/jjs/UserBridgeTest.gwt.xml
   A user/test/com/google/gwt/dev/jjs/bridge/BaseClass.java
   A user/test/com/google/gwt/dev/jjs/bridge/UserBridgeClass.java
   A user/test/com/google/gwt/dev/jjs/bridge/UserBridgeTest.java



--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to