The fix looks good, but I don't think that any tests beyond the first
are validating that the load sequence is working correctly.


http://gwt-code-reviews.appspot.com/43802/diff/1/4
File user/test/com/google/gwt/dev/jjs/InitialLoadSequence.gwt.xml
(right):

http://gwt-code-reviews.appspot.com/43802/diff/1/4#newcode2
Line 2: <!-- Copyright 2007 Google Inc.
            -->
2009

http://gwt-code-reviews.appspot.com/43802/diff/1/3
File user/test/com/google/gwt/dev/jjs/test/InitialLoadSequenceTest.java
(right):

http://gwt-code-reviews.appspot.com/43802/diff/1/3#newcode45
Line 45: public void testInOrder() {
Unless the app is re-loaded, will any tests other than the first
actually verify that the loading sequence is behaving as desired?

http://gwt-code-reviews.appspot.com/43802

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to