Reviewers: scottb, Lex, Message: Request review.
http://gwt-code-reviews.appspot.com/44803/diff/1/2 File dev/core/src/com/google/gwt/dev/js/JsInliner.java (right): http://gwt-code-reviews.appspot.com/44803/diff/1/2#newcode916 Line 916: } Actual changes are above. From here to the next comment is unchanged, the diff algorithm isn't making a good choice. http://gwt-code-reviews.appspot.com/44803/diff/1/2#newcode1002 Line 1002: private JsExpression process(JsInvocation x, JsFunction callerFunction, This is the new function. Description: The actual diff in JsInliner isn't actually as big as it seems, I broke most of endVisit(JsInvocation) out into a separate private function. This is a more robust version of the fix in r5585. It adds tracking a stack of functions that the InliningVisitor is currently attempting to inline and refuses to inline another invocation of a function currently being inlined. Please review this at http://gwt-code-reviews.appspot.com/44803 Affected files: M dev/core/src/com/google/gwt/dev/js/JsInliner.java M dev/core/test/com/google/gwt/dev/js/JsInlinerTest.java --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
