LGTM, with comment.

http://gwt-code-reviews.appspot.com/46802/diff/1/3
File dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRebinds.java
(right):

http://gwt-code-reviews.appspot.com/46802/diff/1/3#newcode95
Line 95: // Proper JSNI ref
Shouldn't most of this lookup logic be duplicated elsewhere for
resolving jsni refs in general?  IOW, we should factor out a static
method if necessary and share code.

http://gwt-code-reviews.appspot.com/46802

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to