On 2009/07/02 20:58:49, jat wrote:
> LGTM other than removing the Safari2 support.

> http://gwt-code-reviews.appspot.com/48806/diff/1/3
> File user/test/com/google/gwt/user/client/rpc/UnicodeEscapingTest.java
(left):

> http://gwt-code-reviews.appspot.com/48806/diff/1/3#oldcode66
> Line 66: private static native boolean isSafari2() /*-{
> Don't we still need this?  Until we official drop support for Safari2
(and our
> build doesn't test it), I think we need to keep the test passing
there.

We (and just about everyone else) officially dropped support for Safari
2 some time ago. It was uncontroversial when discussed on gwt-contrib.

http://gwt-code-reviews.appspot.com/48806

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to