LGTM; Sorry for the delay.
http://gwt-code-reviews.appspot.com/47806/diff/1/3 File dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java (right): http://gwt-code-reviews.appspot.com/47806/diff/1/3#newcode413 Line 413: private static void installInitialLoadSequenceField(JProgram program, Add a comment with an example of the AST this should create. http://gwt-code-reviews.appspot.com/47806/diff/1/11 File user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java (right): http://gwt-code-reviews.appspot.com/47806/diff/1/11#newcode86 Line 86: Integer size); Document why the arguments are boxed. http://gwt-code-reviews.appspot.com/47806/diff/1/11#newcode202 Line 202: private static class StandardLoadingStrategy implements LoadingStrategy { Rename to XhrLoadingStrategy to be more descriptive. http://gwt-code-reviews.appspot.com/47806/diff/1/11#newcode204 Line 204: String fragmentUrl = gwtStartLoadingFragment(fragment, loadErrorHandler); Can this be renamed to something like "maybeGetFragmentUrl"? http://gwt-code-reviews.appspot.com/47806/diff/1/11#newcode206 Line 206: if (fragmentUrl != null) { Invert logic and return early? http://gwt-code-reviews.appspot.com/47806/diff/1/11#newcode213 Line 213: public void onReadyStateChange(XMLHttpRequest xhr) { This parameter masks the final variable. http://gwt-code-reviews.appspot.com/47806/diff/1/11#newcode236 Line 236: private native void gwtInstallCode(String text) /*-{ Please add some javadoc. It would be helpful to indicate where any eval errors would be reported. http://gwt-code-reviews.appspot.com/47806/diff/1/11#newcode277 Line 277: evt.fragment = fragme...@java.lang.integer::intValue()(); When would there not be a fragment number? http://gwt-code-reviews.appspot.com/47806/diff/1/11#newcode280 Line 280: evt.size = si...@java.lang.integer::intValue()(); Is the boxing necessary for size? When is a zero-size ever a correct value? http://gwt-code-reviews.appspot.com/47806 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
