LGTM, pending an LGTM on the other conditional property patch

http://gwt-code-reviews.appspot.com/56816/diff/1/6
File user/src/com/google/gwt/junit/JUnit.gwt.xml (right):

http://gwt-code-reviews.appspot.com/56816/diff/1/6#newcode34
Line 34: <!-- TODO(bobv): This is temporary until
subset-of-permutation-matrix work is done. -->
Probably want to remove this now?

http://gwt-code-reviews.appspot.com/56816/diff/1/6#newcode44
Line 44: </set-property>
To double-check, you're leaving these off because you  know that they
can already generate their own stack traces without emulation?

http://gwt-code-reviews.appspot.com/56816

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to