LGTM if you implement all the suggestions.
http://gwt-code-reviews.appspot.com/57802/diff/1001/54 File dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java (right): http://gwt-code-reviews.appspot.com/57802/diff/1001/54#newcode73 Line 73: return conditionalValues; Better to make it unmodifiable to prevent future errors from creeping in http://gwt-code-reviews.appspot.com/57802/diff/1001/65 File dev/core/src/com/google/gwt/dev/cfg/ModuleDefSchema.java (right): http://gwt-code-reviews.appspot.com/57802/diff/1001/65#newcode323 Line 323: protected Schema __extend_property_begin(BindingProperty property, Let's remove the ability to use conditionals on <extend-property> for now, as we discussed on the phone. http://gwt-code-reviews.appspot.com/57802/diff/1001/68 File dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java (right): http://gwt-code-reviews.appspot.com/57802/diff/1001/68#newcode88 Line 88: + bindingProps.toString()); BindingProperty.toString() isn't implement; need to make it pretty for this error message to make sense http://gwt-code-reviews.appspot.com/57802/diff/1001/70 File dev/core/src/com/google/gwt/dev/shell/ModuleSpacePropertyOracle.java (right): http://gwt-code-reviews.appspot.com/57802/diff/1001/70#newcode196 Line 196: values = prop.getAllowedValues(winner); can you assign at declaration in 195 http://gwt-code-reviews.appspot.com/57802 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
