2009/8/18 Freeland Abbott <fabb...@google.com>: > Looks fine... the only comments are pretty cosmetic: changing > checkTypeInstantiable() (and checkArrayInstantiable() also) to return > non-boolean should probably also change its name; something like > computeInstantiability() may be a better name. It also may warrant more > explicit javadoc. It just feels very, very odd to me to have the return > value of "check...." then have additional methods to call!
Agreed! I'll change the name to computeInstantiability. Also, I simply forgot about the javadoc; I'll update it. -Lex --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
