LGTM with nits.
http://gwt-code-reviews.appspot.com/62804/diff/1/2 File user/src/com/google/gwt/resources/css/GenerateCssAst.java (left): http://gwt-code-reviews.appspot.com/62804/diff/1/2#oldcode695 Line 695: Missing newline? http://gwt-code-reviews.appspot.com/62804/diff/1/2 File user/src/com/google/gwt/resources/css/GenerateCssAst.java (right): http://gwt-code-reviews.appspot.com/62804/diff/1/2#newcode747 Line 747: * @param color typed value from CSS parse, which may be an INTEGER or a parseR http://gwt-code-reviews.appspot.com/62804/diff/1/2#newcode760 Line 760: throw new IllegalArgumentException( If you throw new CSSException(CSSException.SAC_SYNTAX_ERROR, "...") the parser will fail with a more useful user-facing error message. http://gwt-code-reviews.appspot.com/62804 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---