My 2 c€nts.
Overall, it leads to reworking the patch as an:
if (method is GET (or HEAD)) {
if (url contains ".nocache.") {
set no-cache headers
} else if (url contains ".cache".) {
set forever-cache headers
}
}
// otherwise (non-GET/HEAD, or non-nocache/cache URL), just do nothing
regarding caching (or at least fallback to default)
An application developer can use the following in its web.xml to change
the default behavior for static files (and cache them for 60 seconds):
<context-param>
<param-name>org.mortbay.jetty.servlet.Default.cacheControl</param-name>
<param-value>max-age=60,public</param-value>
</context-param>
http://gwt-code-reviews.appspot.com/56807/diff/1/2
File dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java
(right):
http://gwt-code-reviews.appspot.com/56807/diff/1/2#newcode450
Line 450: // to be safe, mark all non-GETs as non-cacheable
Er, responses to non-GET/HEAD requests *are* non-cacheable by default
(as a consequence of the "write-through mandatory" constraint from HTTP
http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html#sec13.11 ), so
this is useless IMO.
http://gwt-code-reviews.appspot.com/56807/diff/1/2#newcode471
Line 471: // everything else gets public caching for 60 seconds
Why? why not (again) rely on the default caching behavior?
http://gwt-code-reviews.appspot.com/56807
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
