LGTM then. On Fri, Sep 25, 2009 at 12:09 PM, BobV <b...@google.com> wrote:
> > Good question, I have an 3.3 based Eclipse that's probably out of date > now, > > and should probably update. But I was talking less about the particular > > settings, and more meant to suggest committing the reformat separately so > as > > to make clear the syntactic vs. semantic change in the history. > > ACK. > > > I'm sure you're right on this, but as I haven't looked into it deeply, I > > don't quite understand your explanation. Specifically, what would break > if > > you simply deleted lines 181-194 (inclusive) and changed like 197 to > > "getAllOverrides". In other words: > > Nothing would break, it's just asking a less precise question. Since > it's less code that's functionally equivalent, I'll make the change. > > -- > Bob Vawter > Google Web Toolkit Team > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
