IMHO if they're legal, who cares about the conventions? These aren't really conventional interfaces.
On Fri, Oct 2, 2009 at 2:25 PM, <kplatf...@google.com> wrote: > > http://gwt-code-reviews.appspot.com/72808/diff/1/2 > File user/src/com/google/gwt/resources/css/InterfaceGenerator.java > (right): > > http://gwt-code-reviews.appspot.com/72808/diff/1/2#newcode202 > Line 202: if (!Character.isJavaIdentifierPart(c)) { > I recently wrote a very similar method for the plugin, which also > generates CssResource interfaces from .css files. In my version, I used > Character.isLetterOrDigit rather than isJavaIdentifierPart. The problem > is that isJavaIdentifierPart returns true for certain characters > (underscores, among others) that are technically valid but which would > produce method names that violate Java convention, e.g.: > "save_button()" > > http://gwt-code-reviews.appspot.com/72808 > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
